Skip to content

Install rename #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Install rename #5103

merged 1 commit into from
Mar 21, 2025

Conversation

LiamConnors
Copy link
Member

The Makefile here for the docs build uses rename https://github.com/plotly/plotly.py/blob/main/doc/apidoc/Makefile#L39
but the most recent time the docs were deployed this failed.

The HTML pages are in _build/html.
git checkout -- ../../plotly/graph_objs
# Remove files which were added only for docstring generation
rm ../../plotly/colors/diverging.py ../../plotly/colors/sequential.py ../../plotly/colors/qualitative.py ../../plotly/colors/cyclical.py ../../plotly/colors/colorbrewer.py ../../plotly/colors/carto.py ../../plotly/colors/cmocean.py
rm ../../plotly/express/colors/diverging.py ../../plotly/express/colors/sequential.py ../../plotly/express/colors/qualitative.py ../../plotly/express/colors/cyclical.py ../../plotly/express/colors/colorbrewer.py ../../plotly/express/colors/carto.py ../../plotly/express/colors/cmocean.py
rename 's/graph_objs/graph_objects/' _build/html/*.html _build/html/generated/*.html _build/html/generated/generated/*.html
/bin/sh: 1: rename: not found
make: *** [Makefile:39: html] Error 127

Exited with code exit status 2

@emilykl @marthacryan are you aware of anything that would have changed. I know we did some updates to the config.yml file recently.

@LiamConnors LiamConnors requested a review from gvwilson March 20, 2025 16:44
@LiamConnors LiamConnors mentioned this pull request Mar 20, 2025
Closed
@emilykl
Copy link
Contributor

emilykl commented Mar 20, 2025

aha -- looks like the rename install was (misleadingly) part of the Orca install step and so it got deleted when we removed the Orca tests:

fab49c7

LGTM @LiamConnors !

@LiamConnors LiamConnors merged commit 3763b5f into doc-prod Mar 21, 2025
5 checks passed
@LiamConnors LiamConnors deleted the add-rename branch March 21, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvwilson gvwilson gvwilson approved these changes

@emilykl emilykl emilykl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiamConnors @emilykl @gvwilson